lorenzo.volpi
/
QuaPy
forked from moreo/QuaPy
1
0
Fork 0
Code Pull Requests Activity

bugfix when refit=False in model selection

This commit is contained in:
Alejandro Moreo Fernandez 2021-06-16 13:23:44 +02:00
parent 4f07680381
commit 294e251450
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
quapy/model_selection.py
View File

@ -179,8 +179,7 @@ class GridSearchQ(BaseQuantifier):
if self.best_score_ is None or score < self.best_score_: if self.best_score_ is None or score < self.best_score_:
self.best_score_ = score self.best_score_ = score
self.best_params_ = params self.best_params_ = params
if not self.refit: self.best_model_ = deepcopy(model)
self.best_model_ = deepcopy(model)
self.param_scores_[str(params)] = score self.param_scores_[str(params)] = score
if self.timeout > 0: if self.timeout > 0:
@ -193,8 +192,8 @@ class GridSearchQ(BaseQuantifier):
raise TimeoutError('all jobs took more than the timeout time to end') raise TimeoutError('all jobs took more than the timeout time to end')
self.sout(f'optimization finished: best params {self.best_params_} (score={self.best_score_:.5f})') self.sout(f'optimization finished: best params {self.best_params_} (score={self.best_score_:.5f})')
model.set_params(**self.best_params_) # model.set_params(**self.best_params_)
self.best_model_ = deepcopy(model) # self.best_model_ = deepcopy(model)
if self.refit: if self.refit:
self.sout(f'refitting on the whole development set') self.sout(f'refitting on the whole development set')