manolas
/
vcglib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #64 from norbertwenzel/virtual_dtor_cleanup 

Fix missing virtual destructor warnings
This commit is contained in:
Alessandro Muntoni 2020-03-30 10:08:40 +02:00 committed by GitHub
parent d0cd299f34 d0c135e0e0
commit 2d35e3964d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vcg/complex/algorithms/hole.h
View File

@ -100,6 +100,8 @@ public:
ComputeQuality(); ComputeQuality();
ComputeAngle(); ComputeAngle();
} }
// enforce virtual dtor for this class and all subclasses
virtual ~TrivialEar() = default;
/// Compute the angle of the two edges of the ear. /// Compute the angle of the two edges of the ear.
// it tries to make the computation in a precision safe way. // it tries to make the computation in a precision safe way.

2
wrap/openfbx/src/ofbx.cpp
View File

@ -355,7 +355,7 @@ struct Property : IElementProperty
}; };
struct Element : IElement struct Element final : IElement
{ {
IElement* getFirstChild() const override { return child; } IElement* getFirstChild() const override { return child; }
IElement* getSibling() const override { return sibling; } IElement* getSibling() const override { return sibling; }