manolas
/
vcglib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

IMPORTANT CHANGE; 

the rarely used frompolar and topolar returns angles in RADIANTS
changed the function names to clarify, avoid stupid bugs, and to adequate to the standard
This commit is contained in:
Paolo Cignoni 2010-05-04 08:07:18 +00:00
parent 9ca3dc0855
commit c41e4d2e04
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
vcg/space/deprecated_point3.h
View File

@ -337,14 +337,14 @@ public:
/** /**
* Convert to polar coordinates from cartesian coordinates. * Convert to polar coordinates from cartesian coordinates.
* *
* Theta is the azimuth angle and ranges between [0, 360) degrees. * Theta is the azimuth angle and ranges between [0, 2PI) degrees.
* Phi is the elevation angle (not the polar angle) and ranges between [-90, 90] degrees. * Phi is the elevation angle (not the polar angle) and ranges between [-PI/2, PI/2] degrees.
* *
* /note Note that instead of the classical polar angle, which ranges between * /note Note that instead of the classical polar angle, which ranges between
* 0 and 180 degrees we opt for the elevation angle to obtain a more * 0 and PI degrees we opt for the elevation angle to obtain a more
* intuitive spherical coordinate system. * intuitive spherical coordinate system.
*/ */
void ToPolar(P3ScalarType &ro, P3ScalarType &theta, P3ScalarType &phi) const void ToPolarRad(P3ScalarType &ro, P3ScalarType &theta, P3ScalarType &phi) const
{ {
ro = Norm(); ro = Norm();
theta = (P3ScalarType)atan2(_v[2], _v[0]); theta = (P3ScalarType)atan2(_v[2], _v[0]);
@ -354,14 +354,14 @@ public:
/** /**
* Convert from polar coordinates to cartesian coordinates. * Convert from polar coordinates to cartesian coordinates.
* *
* Theta is the azimuth angle and ranges between [0, 360) degrees. * Theta is the azimuth angle and ranges between [0, 2PI) degrees.
* Phi is the elevation angle (not the polar angle) and ranges between [-90, 90] degrees. * Phi is the elevation angle (not the polar angle) and ranges between [-90, 90] degrees.
* *
* \note Note that instead of the classical polar angle, which ranges between * \note Note that instead of the classical polar angle, which ranges between
* 0 and 180 degrees, we opt for the elevation angle to obtain a more * 0 and PI degrees, we opt for the elevation angle to obtain a more
* intuitive spherical coordinate system. * intuitive spherical coordinate system.
*/ */
void FromPolar(const P3ScalarType &ro, const P3ScalarType &theta, const P3ScalarType &phi) void FromPolarRad(const P3ScalarType &ro, const P3ScalarType &theta, const P3ScalarType &phi)
{ {
_v[0]= ro*cos(theta)*cos(phi); _v[0]= ro*cos(theta)*cos(phi);
_v[1]= ro*sin(phi); _v[1]= ro*sin(phi);