manolas
/
vcglib
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove unused overloads that do not compile 

The `ReadHeader()` overloads taking a character pointer (filename) as a
first parameter instead of a `FILE*` directly do not compile, as they
are calling an overload of `ReadHeader(FILE*)` which does not exist.
Clang does not seem to care as these functions are unused when compiling
MeshLab (and therefore also VCGLib) but GCC tries to compile these
(unused) functions and rightly fails.

This commit simply removes the overloads taking a filename (`char*`).
They are in a header, but since they should fail to compile on *any*
platform I guess it is safe to remove these overloads, as I do not
expect them to be used anywhere successfully.
This commit is contained in:
Norbert Wenzel 2019-10-27 08:34:13 +01:00
parent 910da4c3e3
commit d1c9bd68a0
2 changed files with 0 additions and 18 deletions

9
wrap/io_trimesh/import_nvm.h
View File

@ -85,15 +85,6 @@ static bool ReadHeader(FILE *fp,unsigned int &num_cams){
return true;
}
static bool ReadHeader(const char * filename,unsigned int &/*num_cams*/, unsigned int &/*num_points*/){
FILE *fp = fopen(filename, "r");
if(!fp) return false;
ReadHeader(fp);
fclose(fp);
return true;
}
static int Open( OpenMeshType &m, std::vector<Shot<ScalarType> > & shots,
std::vector<std::string > & image_filenames,
const char * filename, CallBackPos *cb=0)

9
wrap/io_trimesh/import_out.h
View File

@ -85,15 +85,6 @@ static bool ReadHeader(FILE *fp,unsigned int &num_cams, unsigned int &num_points
return true;
}
static bool ReadHeader(const char * filename,unsigned int &/*num_cams*/, unsigned int &/*num_points*/){
FILE *fp = fopen(filename, "r");
if(!fp) return false;
ReadHeader(fp);
fclose(fp);
return true;
}
static int Open( OpenMeshType &m, std::vector<Shot<ScalarType> > & shots,
std::vector<std::string > & image_filenames,
const char * filename,const char * filename_images, CallBackPos *cb=0)